Detailed hvac viewer - #31
Merged
Merged
Conversation
add dropdown menu
updated wrong measure.rb
- change image names to match the OS object type - include another path option for image lookup so they will show when running tests - update .gitignore to ignore all test outputs
- removes hardcoded gridData json - adds populateGrid to create the gridData object necessary for plotting - adds createGrid to assign positions in the grid - adds assignImage to return the image file for a given object type - adds splitOutdoorAirSystemObjects to split the outdoor air system object into two for grid plotting purposes. handles node attachments and assignments - takes hvac_data out of an array; it is already an array. adapt code to account for the change. - change high level names from object_name to loop_name - change component_type to component_side for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An important update that dynamically creates the graph from the HVAC data, instead of being hardcoded to the example file